Fix infinite recursion when walking Abstractions#217
Merged
Conversation
This was referenced Jul 11, 2024
piegamesde
suggested changes
Jul 12, 2024
Member
piegamesde
left a comment
piegamesde
left a comment
There was a problem hiding this comment.
Please make the commit message more clear that this is about the walkSubprogram, because it is only used for debugging regressions and does not affect program execution otherwise
infinisil
force-pushed
the
fix-infinite-verify-recursion
branch
from
e838fd5 to
4aaab56
Compare
piegamesde
approved these changes
Jul 12, 2024
This caused an infinite recursion when trying to minimise the
non-idempotency when running --verify on
{
foo
# bar
, baz # qux
}:
null
infinisil
force-pushed
the
fix-infinite-verify-recursion
branch
from
4aaab56 to
baa4bb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused an infinite recursion when trying to minimise the non-idempotency when running --verify on
This work is sponsored by Antithesis ✨