Skip to content

Fix #188#193

Closed
piegamesde wants to merge 1 commit intoNixOS:masterfrom
piegamesde:dev
Closed

Fix #188#193
piegamesde wants to merge 1 commit intoNixOS:masterfrom
piegamesde:dev

Conversation

@piegamesde
Copy link
Member

Fixes #188

@infinisil
Copy link
Member

infinisil commented Apr 16, 2024

For now we shouldn't open PRs from a fork because it doesn't seem to work with the Nixpkgs diff check (#194), please open another one from this repo directly.

Edit: This is now fixed with #196 :D

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2024-04-16/43533/1

@github-actions
Copy link

github-actions bot commented May 14, 2024

Nixpkgs diff

@infinisil infinisil force-pushed the dev branch 2 times, most recently from c14ad53 to 7e1570c Compare May 14, 2024 16:08
@infinisil infinisil mentioned this pull request May 14, 2024
@infinisil
Copy link
Member

Looking more closely into this, I don't think this is the right fix. See #201 instead

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2024-05-14/45433/1

@tomberek
Copy link
Contributor

Closing. Using #201

@tomberek tomberek closed this May 28, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2024-05-28/46126/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Reaching a stable list formatting requires formatting twice

4 participants