Conversation
Commit d536c57 inadvertedly broke build and installation of all non-autogenerated manual pages (in particular, all the ones documenting the stable CLI), by moving the definition of the man-pages variable in doc/manual/local.mk after its usage in mk/lib.mk. Move including the former earlier so that the correct order is restored.
Member
|
Thank you! |
Contributor
Author
|
I'm not sure the backports to 2.18 and 2.19 are needed, as it seems the regression was not backported either. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.18-maintenance
git worktree add -d .worktree/backport-9976-to-2.18-maintenance origin/2.18-maintenance
cd .worktree/backport-9976-to-2.18-maintenance
git switch --create backport-9976-to-2.18-maintenance
git cherry-pick -x 8f3253c6f4041f500631e1dac5ba75f335e9c70a |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.19-maintenance
git worktree add -d .worktree/backport-9976-to-2.19-maintenance origin/2.19-maintenance
cd .worktree/backport-9976-to-2.19-maintenance
git switch --create backport-9976-to-2.19-maintenance
git cherry-pick -x 8f3253c6f4041f500631e1dac5ba75f335e9c70a |
|
Successfully created backport PR for |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
Docs build: depend on locally built nix executable and not installed one (cherry picked from commit ca72e3e) === includes changes from (because not doing so removes manpages): Merge pull request NixOS#9976 from alois31/restore-manual-pages Restore manual pages (cherry picked from commit d3c1997) Change-Id: I685ff16163ac552a1754570c03c992c63a461d50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit d536c57 inadvertedly broke build and installation of all non-autogenerated manual pages (in particular, all the ones documenting the stable CLI), by moving the definition of the man-pages variable in doc/manual/local.mk after its usage in mk/lib.mk. Move including the former earlier so that the correct order is restored.
Motivation
Documentation is important. There should not be regressions.
Context
Regression caused by #5145.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.