libutil/libexpr: Remove frame trace distinction#9772
Closed
roberth wants to merge 1 commit intoNixOS:masterfrom
Closed
libutil/libexpr: Remove frame trace distinction#9772roberth wants to merge 1 commit intoNixOS:masterfrom
roberth wants to merge 1 commit intoNixOS:masterfrom
Conversation
Simplifies the code and interface, and prints *some* more trace items. I have gotten more value out of removing frame when working on errors and adding tests (in other branches), so it seems that our test suite is still lacking a bit when it comes to the range of errors.
roberth
added
error-messages
github-actions
bot
added
the
with-tests
edolstra
added
the
idea approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Simplifies the code and interface, and prints some more trace items. I have gotten more value out of removing frame when working on errors and adding tests (in other branches), so it seems that our test suite is still lacking a bit when it comes to the range of errors that we test.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.