absPath: just take a std::string_view#9759
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 15, 2024
Merged
Conversation
Ericson2314
force-pushed
the
abs-path-string-view
branch
3 times, most recently
from
37242eb to
1cde990
Compare
cole-h
reviewed
Jan 13, 2024
Ericson2314
force-pushed
the
abs-path-string-view
branch
from
6cca5df to
ad0faf5
Compare
roberth
reviewed
Jan 15, 2024
1. Slightly more efficient 2. Easier to call Co-authored-by: Cole Helbling <[email protected]>
Ericson2314
force-pushed
the
abs-path-string-view
branch
from
ad0faf5 to
beed00c
Compare
roberth
approved these changes
Jan 15, 2024
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 15, 2024
I found a way to avoid the `scratch` variable I just introduced in NixOS#9759, but I am not sure whether this makes this code easier or harder to read 😅.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 15, 2024
I found a way to avoid the `scratch` variable I just introduced in NixOS#9759, but I am not sure whether this makes this code easier or harder to read 😅.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 15, 2024
I found a way to avoid the `scratch` variable I just introduced in NixOS#9759, but I am not sure whether this makes this code easier or harder to read 😅.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 15, 2024
I found a way to avoid the `scratch` variable I just introduced in NixOS#9759, but I am not sure whether this makes this code easier or harder to read 😅.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 15, 2024
I found a way to avoid the `scratch` variable I just introduced in NixOS#9759, but I am not sure whether this makes this code easier or harder to read 😅.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 15, 2024
I found a way to avoid the `scratch` variable I just introduced in NixOS#9759, but I am not sure whether this makes this code easier or harder to read 😅.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 15, 2024
I found a way to avoid the `scratch` variable I just introduced in NixOS#9759, but I am not sure whether this makes this code easier or harder to read 😅.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 17, 2024
I found a way to avoid the `scratch` variable I just introduced in NixOS#9759, but I am not sure whether this makes this code easier or harder to read 😅.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jan 17, 2024
I found a way to avoid the `scratch` variable I just introduced in NixOS#9759, but I am not sure whether this makes this code easier or harder to read 😅.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Slightly more efficient
Easier to call
Context
(Noticed this while cleaning up path things for Windows.)
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.