Some small Makefile improvements to prepare for Windows support#9736
Merged
Ericson2314 merged 3 commits intoNixOS:masterfrom Jan 11, 2024
Merged
Some small Makefile improvements to prepare for Windows support#9736Ericson2314 merged 3 commits intoNixOS:masterfrom
Ericson2314 merged 3 commits intoNixOS:masterfrom
Conversation
Tab (as required) for rules, two spaces for `if`...`endif`.
We don't want this with MinGW.
github-actions
bot
added
new-cli
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
8 tasks
wegank
approved these changes
Jan 11, 2024
Mindavi
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A few misc things to get ready.
Context
#8901 will take advantage of this.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
CC @wegank