Skip to content

Comments

[Backport 2.19-maintenance] Factor out StoreDirConfig#9562

Closed
Ericson2314 wants to merge 2 commits intoNixOS:2.19-maintenancefrom
obsidiansystems:store-dir-config-2.19
Closed

[Backport 2.19-maintenance] Factor out StoreDirConfig#9562
Ericson2314 wants to merge 2 commits intoNixOS:2.19-maintenancefrom
obsidiansystems:store-dir-config-2.19

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Dec 7, 2023 •
edited
Loading

Motivation

Backport of #6236

Reasons:

  • This PR is touches a lot of code, so it could get in the way of other backports. I would backport it all the way back to 2.18. For that reason.
  • The PR is very safe/boring refactor --- it moves some headers around and then is a giant sed --- so it's highly unlikely to have any accidental behavior change
  • StoreDirConfig vs Store is useful for reasoning about code, and I really want to be able to make things StoreDirConfig in Hydra to keep builder vs localStore/evalStore vs destStore straight in my head. :)

Context

#6236

Priorities

Add 👍 to pull requests you find important.

@Ericson2314
Factor out StoreDirConfig
756eeae 
More progress on NixOS#5729.

(cherry picked from commit e97ac09)
@Ericson2314
Restrict some code to StoreDirConfig
4d507a3 
 - part of eval cache
 - part of derivations
 - derived path
 - store path with outputs
 - serializers

(cherry picked from commit dde1d86)
(cherry picked from commit d59bdbe)
@Ericson2314 Ericson2314 requested a review from roberth December 7, 2023 22:20
@github-actions github-actions bot added new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store labels Dec 7, 2023
@Ericson2314 Ericson2314 mentioned this pull request Dec 7, 2023
Closed
@Ericson2314 Ericson2314 marked this pull request as draft December 8, 2023 13:09
@thufschmitt thufschmitt closed this Dec 8, 2023
@nixos-discourse
Copy link

nixos-discourse commented Dec 11, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-12-08-nix-team-meeting-minutes-110/36721/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth Awaiting requested review from roberth

@thufschmitt thufschmitt Awaiting requested review from thufschmitt

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees

No one assigned

Labels

new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ericson2314 @nixos-discourse @thufschmitt