Factor out ServeProto::Serialiser<UnkeyedValidPathInfo> and test#9560
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Dec 8, 2023
Conversation
github-actions
bot
added
the
store
13 tasks
In the process, partially undo e89b5bd in that the ancient < 2.4 version is now supported again by the serializer again. `LegacySSHStore`, instead of also asserting that the version is at least 4, just checks that `narHash` is set. This allows us to better test the serializer in isolation for both versions (< 4 and >= 4).
Ericson2314
force-pushed
the
serve-proto-unkeyed-valid-path-info-serializer
branch
from
c473a88 to
a5521b7
Compare
tomberek
approved these changes
Dec 8, 2023
Contributor
tomberek
left a comment
tomberek
left a comment
There was a problem hiding this comment.
Refactor. New methods support strictly more use cases. Helps de-dup parsing behavior. Will be helpful when trying to refactor the daemon protocol.
Ericson2314
deleted the
serve-proto-unkeyed-valid-path-info-serializer
branch
Ericson2314
added a commit
to NixOS/hydra
that referenced
this pull request
Dec 9, 2023
Companion to already-merged NixOS/nix#9560
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
…d-valid-path-info-serializer Factor out `ServeProto::Serialiser<UnkeyedValidPathInfo>` and test (cherry picked from commit 1399829) Change-Id: I28e4ba5a681a90d81915a56e6dbaa5456d64f96d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Better testing, Hydra dedup
Context
In the process, partially undo e89b5bd in that the ancient < 2.4 version is now supported again by the serializer again.
LegacySSHStore, instead of also asserting that the version is at least 4, just checks thatnarHashis set.This allows us to better test the serializer in isolation for both versions (< 4 and >= 4).
Priorities
Add 👍 to pull requests you find important.