Rename nix doctor to nix config check#9478
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Dec 1, 2023
Merged
Conversation
thufschmitt
requested review from
edolstra and
fricklerhandwerk
as code owners
github-actions
bot
added
documentation
new-cli
| void run() override | ||
| { | ||
| if (!command) | ||
| throw UsageError("'nix config' requires a sub-command."); |
Contributor
There was a problem hiding this comment.
Shouldn't we show the equivalent of nix config --help here instead? Not necessarily blocking, but it could be a quick fix with a tangible UX impact, and also set a good example.
Member
Author
There was a problem hiding this comment.
I followed what other commands are doing without thinking too much 😛
I think failing here is good (because I might accidentally write that in a script, and I'd be glad if Nix tells me that it's a mistake), but also showing the help (or at least the list of commands) could make a lot of sense
Member
There was a problem hiding this comment.
I guess we can have an issue to factor this out :)
thufschmitt
force-pushed
the
nix-config-check
branch
from
1c2a01c to
6d16058
Compare
edolstra
approved these changes
Nov 30, 2023
Ericson2314
reviewed
Dec 1, 2023
Ericson2314
approved these changes
Dec 1, 2023
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Minor nit about what in what file, otherwise good!
github-actions
bot
removed
documentation
with-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Fix #7672
Priorities
Add 👍 to pull requests you find important.