Revert use of boost::container::small_vector in the evaluator#9399
Merged
roberth merged 1 commit intoNixOS:masterfrom Nov 20, 2023
Merged
Revert use of boost::container::small_vector in the evaluator#9399roberth merged 1 commit intoNixOS:masterfrom
roberth merged 1 commit intoNixOS:masterfrom
Conversation
It caused random crashes (https://hydra.nixos.org/build/241514506, https://hydra.nixos.org/build/241443330) because the heap allocation done by small_vector in the not-small case is not scanned for GC roots.
roberth
approved these changes
Nov 20, 2023
2 tasks
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
Revert use of boost::container::small_vector in the evaluator (cherry picked from commit 6832d18) Change-Id: I7f10af0c8b8a8beb4b1e36424120995f4ed82738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #7348 caused random crashes (https://hydra.nixos.org/build/241514506, https://hydra.nixos.org/build/241443330) because the heap allocation done by small_vector in the not-small case is not scanned for GC roots.
This is probably fixable but let's revisit this after the new release.
Context
Priorities
Add 👍 to pull requests you find important.