Merged
Conversation
thufschmitt
requested review from
edolstra and
fricklerhandwerk
as code owners
github-actions
bot
added
documentation
new-cli
thufschmitt
force-pushed
the
nix-store-add
branch
from
f861860 to
0e47ea3
Compare
Ericson2314
approved these changes
Nov 15, 2023
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Looks good! Just needs change log entry I think.
I forgot whether we talked about it. I think this should support text hashing too, but it is easiest to do that after #9325 so I am OK not doing it for now.
thufschmitt
force-pushed
the
nix-store-add
branch
from
0e47ea3 to
53f5da3
Compare
Member
Author
Ah good catch, I always forget about these. @fricklerhandwerk, I received a notification with a suggestion from you which disappeared from here. It was good so I've applied it nonetheless. |
Member
|
Oh sorry one more thing I missed: |
Deprecate `nix store add-file` and `nix store add-path`, and replace them with a single `nix store add` command.
thufschmitt
force-pushed
the
nix-store-add
branch
from
53f5da3 to
8412846
Compare
Member
Author
|
Grmbl, indeed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Deprecate
nix store add-fileandnix store add-path, and replace them with a singlenix store addcommand.Context
Fix #8915
Priorities
Add 👍 to pull requests you find important.