test precedence for setting the search path#9066
Draft
fricklerhandwerk wants to merge 1 commit intoNixOS:masterfrom
Draft
test precedence for setting the search path#9066fricklerhandwerk wants to merge 1 commit intoNixOS:masterfrom
fricklerhandwerk wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
with-tests
fricklerhandwerk
force-pushed
the
nix-path-tests
branch
from
3fe2c8e to
813701c
Compare
this is just to show the principle. the test cases are incomplete and way too manual.
fricklerhandwerk
force-pushed
the
nix-path-tests
branch
from
813701c to
a5b4d8e
Compare
8 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Contributor
Author
|
Note: Update documentation accordingly once this is fixed https://github.com/NixOS/nix/pull/9113/files#r1487801059 |
This was referenced May 6, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is just to show the principle for now.
the test cases are incomplete and way too manual.
the complete specification should follow this table, and the tests ideally be generated from that automatically:
Motivation
The current behavior being inconsistent and surprising (#8890 #8784) has spawned multiple competing and conflicting attempts of fixing it:
{restrict,pure}-eval#7689Context
developed together with @thufschmitt
this should also resolve the confusion around behavior of
restrict-eval, as that is supposed to only allow explicitly defined search paths.Priorities
Add 👍 to pull requests you find important.