Conversation
buitlins.fetchTreebuitlins.fetchTree
buitlins.fetchTreebuitlins.fetchTree
buitlins.fetchTreebuiltins.fetchTree
|
Please keep I prefer to keep all URL/flakeref-related regexes like |
if we can cut this down I am fine leaving those files in For example, if it isn't flakes-specific we shouldn't call it the Flakes Registry at all. |
bf70b88 to
c5e57ea
Compare
|
#9085 My crude attempt to make indirect/registry demonstrably Flake-agnostic by renaming things. I will need some help finishing that PR however. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This frees up the name for registries in the traditional sense that contain artifacts of sorts. Still not happy that we overload the term "registry" so I think it's worth taking the opportunity to consider an entirely different name. The How about source index? EDIT: I'm aware that DNS has a prominent concept of registry, but our domain is software development and packaging, not internet infrastructure, so "registry" is more easily assumed to refer to package or artifact registries. Also DNS forms an abstraction where the registry is largely irrelevant to its users. |
builtins.fetchTreelibnixflake
|
@roberth I made #9085 for the approach of renaming it if we will keep it in libfetchers. I think your comment might go better there. I totally agree "registry" is not a good name. (I did (I still think we should have a |
7bf55c3 to
cc2a434
Compare
|
(The registry stuff is kept in libfetchers now) |
roberth
left a comment
There was a problem hiding this comment.
Surprisingly short diff. I like it.
Just a few comments, nothing major.
|
Reminder, this is part of the implementation of RFC 136: https://github.com/NixOS/rfcs/blob/master/rfcs/0136-stabilize-incrementally.md#step-3-attempt-likewise-splitting-a-store-and-language-only-nix |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
8f2c459 to
046059e
Compare
046059e to
23ce736
Compare
Co-authored-by: Robert Hensing <[email protected]>
Co-authored-by: Robert Hensing <[email protected]>
23ce736 to
7181d1f
Compare
It was originally renamed in NixOS#10691, but NixOS#9063 accidentally removed the new name and alias.
|
Sorry! A negligent rebase conflict resolution on my part, no doubt. Thank you @cole-h for fixing my mistake ❤️. |
|
No need to take all the blame; this feature wasn't tested. |
|
Implication heard loud and clear -- I'll add a test in my PR resurrecting it. EDIT: test added |
|
Tests are def good, and objectively the right way to prevent this, but I also pride myself on being a slicing-and-dicing-like-a-sushi-chef rebaser :), so I really was dissapointed I slipped up. |
It was originally renamed in NixOS#10691, but NixOS#9063 accidentally removed the new name and alias.
Motivation
Flakes is a separate layer, so it should have its own library!
Context
See each commit for details. The most interesting code changes (that aren't just moving things around) happen in the first commit.
Priorities
Add 👍 to pull requests you find important.