Merged
Conversation
It was disabled in c6953d1 because a recent Nixpkgs bump brought in a new systemd which changed how systemd-nspawn worked. As far as I can tell, the issue was caused by this upstream systemd commit: systemd/systemd@b71a019 Bind-mounting the host's `/sys` and `/proc` into the container's `/run/host/{sys,proc}` fixes the issue and allows the test to succeed.
github-actions
bot
added
the
with-tests
8 tasks
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
More tests is better than less tests.
Context
It was disabled in c6953d1 because a recent Nixpkgs bump brought in a new systemd which changed how systemd-nspawn worked.
As far as I can tell, the issue was caused by this upstream systemd commit:
systemd/systemd@b71a019
Bind-mounting the host's
/sysand/procinto the container's/run/host/{sys,proc}fixes the issue and allows the test to succeed.Priorities
Add 👍 to pull requests you find important.