Test and begin documentation of the ATerm format for derivations#8927
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Sep 6, 2023
Merged
Test and begin documentation of the ATerm format for derivations#8927Ericson2314 merged 2 commits intoNixOS:masterfrom
Ericson2314 merged 2 commits intoNixOS:masterfrom
Conversation
Wanted to do this before the last dynamic derivations PR when I introduce a variation, to make sure I wasn't changing the old version by mistake.
Ericson2314
requested review from
fricklerhandwerk and
thufschmitt
as code owners
github-actions
bot
added
the
with-tests
This was referenced Sep 5, 2023
| Derivations are serialised in the following format: | ||
|
|
||
| ``` | ||
| Derive(...) |
Contributor
There was a problem hiding this comment.
This surely needs a bit more detail
Member
Author
There was a problem hiding this comment.
The next PR will had some more detail. I just wanted to put something here to have a clear diff.
roberth
reviewed
Sep 6, 2023
roberth
approved these changes
Sep 6, 2023
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Would commit it for you but policy prohibits that in this PR.
Co-authored-by: Robert Hensing <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Wanted to do this before the last dynamic derivations PR when I introduce a variation, to make sure I wasn't changing the old version by mistake.
Context
#4628 is the next one.
Priorities
Add 👍 to pull requests you find important.