Move BuiltPath to its own header/C++ file in libcmd#8691
Merged
roberth merged 1 commit intoNixOS:masterfrom Jul 14, 2023
Merged
Move BuiltPath to its own header/C++ file in libcmd#8691roberth merged 1 commit intoNixOS:masterfrom
BuiltPath to its own header/C++ file in libcmd#8691roberth merged 1 commit intoNixOS:masterfrom
Conversation
It is less important, and used less widely, than `DerivedPath`.
8 tasks
Dessix
approved these changes
Jul 13, 2023
Dessix
left a comment
Dessix
left a comment
There was a problem hiding this comment.
Compiles and seems to work fine for general flake behaviours on x86_64-linux NixOS 23.05. Code appears to be correct and sufficiently unchanged in the refactor.
roberth
approved these changes
Jul 14, 2023
fricklerhandwerk
added
the
contributor-experience
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It is less important, and used less widely, than
DerivedPath.Context
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.