Conversation
8 tasks
thufschmitt
reviewed
Jun 16, 2023
Member
thufschmitt
left a comment
thufschmitt
left a comment
There was a problem hiding this comment.
Big 👍 on the idea, though I'll defer to the doc team for reviewing the content
fricklerhandwerk
approved these changes
Jun 17, 2023
Contributor
fricklerhandwerk
left a comment
fricklerhandwerk
left a comment
There was a problem hiding this comment.
Please reformat to one sentence per line, as this will make changes in the future much less noisy.
Closed
fricklerhandwerk
approved these changes
Jun 24, 2023
Contributor
fricklerhandwerk
left a comment
fricklerhandwerk
left a comment
There was a problem hiding this comment.
This looks good. Not sure if the experimental guard can be already automated. If not, ready to merge from my side.
Contributor
Author
|
I'll get to finish this tomorrow. Sorry for delays. |
Co-authored-by: Valentin Gagarin <[email protected]> Supersedes NixOS#6740
Contributor
Author
|
I made the following changes:
|
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
WiP commit originally included in #8491.
Context
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.