SourcePath::resolveSymlinks(): Fix handling of symlinks that start with '..'#8452
Merged
edolstra merged 1 commit intoNixOS:masterfrom Jun 6, 2023
Merged
Conversation
github-actions
bot
added
fetching
roberth
reviewed
Jun 5, 2023
Contributor
|
Suggestion for commit message: Previously, when resolving a symlink, |
edolstra
force-pushed
the
fix-relative-symlinks
branch
from
6731850 to
2151be5
Compare
github-actions
bot
removed
the
with-tests
Member
|
Can you also add a test case to prevent against this bug in the future? |
This fixes handling of symlinks that start with '..', and symlink targets that contain symlinks themselves.
edolstra
force-pushed
the
fix-relative-symlinks
branch
from
2151be5 to
f5c6b29
Compare
github-actions
bot
added
the
with-tests
Member
Author
|
Added a test. |
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #8437.
Context
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.