Skip to content

Fix 'make check' inside 'nix develop'#7943

Merged
edolstra merged 1 commit intoNixOS:masterfrom
edolstra:fix-make-check
Mar 2, 2023
Merged

Fix 'make check' inside 'nix develop'#7943
edolstra merged 1 commit intoNixOS:masterfrom
edolstra:fix-make-check

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Mar 2, 2023

Motivation

Fixes

$ make check -j24
...
src/libutil/tests/hash.cc:5:10: fatal error: rapidcheck/gtest.h: No such file or directory
    5 | #include <rapidcheck/gtest.h>
      |          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [mk/patterns.mk:3: src/libutil/tests/hash.o] Error 1

Context

Checklist for maintainers

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests - tests/nixos/*
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or incompatible change: updated release notes

@edolstra edolstra merged commit 3a2b3af into NixOS:master Mar 2, 2023
@edolstra edolstra deleted the fix-make-check branch December 9, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants