Add ./configure --disable-tests option#7901
Merged
edolstra merged 3 commits intoNixOS:masterfrom Mar 2, 2023
Merged
Conversation
Building without tests is useful for bootstrapping with a smaller footprint or running the tests in a separate derivation. Otherwise, we do compile and run them. This isn't fine grained as to allow picking `check` but not `installcheck` or vice versa, but it's good enough for now. I've tried to use Nixpkgs' `checkInputs`, but those inputs weren't discovered properly by the configure script. We can emulate its behavior very well though.
fricklerhandwerk
added
the
contributor-experience
Ericson2314
reviewed
Feb 28, 2023
This always forces the setting, rather than relying on its default, and cleans up the code a bit. Co-authored-by: John Ericson <[email protected]>
Ericson2314
approved these changes
Feb 28, 2023
Member
|
@roberth Looks like this broke and $configureFlags does not contain the |
Member
|
#7943 fixes that. |
7 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make incremental progress towards a more testable Nix.
Context
From the commit message:
Building without tests is useful for bootstrapping with a smaller footprint or running the tests in a separate derivation. Otherwise, we do compile and run them.
This isn't fine grained as to allow picking
checkbut notinstallcheckor vice versa, but it's good enough for now.I've tried to use Nixpkgs'
checkInputs, but those inputs weren't discovered properly by the configure script. We can emulate its behavior very well though.Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*