Stratify ExtraPathInfo along Installable hierarchy#7763
Merged
edolstra merged 1 commit intoNixOS:masterfrom Mar 27, 2023
Merged
Stratify ExtraPathInfo along Installable hierarchy#7763edolstra merged 1 commit intoNixOS:masterfrom
ExtraPathInfo along Installable hierarchy#7763edolstra merged 1 commit intoNixOS:masterfrom
Conversation
Ericson2314
changed the title
ExtraPathInfoExtraPathInfo
Ericson2314
force-pushed
the
installable-wide-info
branch
from
ee161ec to
9160e5c
Compare
Ericson2314
force-pushed
the
installable-wide-info
branch
2 times, most recently
from
521e043 to
52e0ab7
Compare
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
installable-wide-info
branch
from
52e0ab7 to
cf8d487
Compare
Instead of having a bunch of optional fields, have a few subclasses which can have mandatory fields. Additionally, the new `getExtraPathInfo`, and `nixpkgsFlakeRef`, are moved to `InstallableValue`. I did these things because NixOS/rfcs#134 ; with these things moved to `InstallableValue`, the base `Installable` no longer depends on libexpr! This is a major step towards that. Also, add a bunch of doc comments for sake of the internal API docs.
Ericson2314
force-pushed
the
installable-wide-info
branch
from
cf8d487 to
256f3e3
Compare
Ericson2314
changed the title
ExtraPathInfoExtraPathInfo along Installable hierarchy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of having a bunch of optional fields, have a few subclasses which can have mandatory fields.
Additionally, the new
getExtraPathInfo, andnixpkgsFlakeRef, are moved toInstallableValue.Also, add a bunch of doc comments for sake of the internal API docs.
Context
I did this because NixOS/rfcs#134 ; with these things moved to
InstallableValue, the baseInstallableno longer depends on libexpr! This is a major step towards that.Depends on #7757Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*