Make --read-only a separate mixin#7755
Merged
thufschmitt merged 1 commit intoNixOS:masterfrom Feb 21, 2023
Merged
Conversation
7 tasks
It is independent of SourceExprCommand, which is about parsing installables, except for the fact that parsing installables is one of the many things influenced by read-only mode.
Ericson2314
force-pushed
the
mix-read-only-mode
branch
from
121c90c to
0258ac9
Compare
Member
Author
|
This is similar in spirit to #7754, which also split out a flag to a mixin. |
tomberek
reviewed
Feb 21, 2023
Contributor
tomberek
left a comment
tomberek
left a comment
There was a problem hiding this comment.
I'm not clear on whether the defaults are changing for read-only. Is InstallableCommand changing to have a default value to true now?
Member
Nah, it shouldn't. The source of truth is |
thufschmitt
approved these changes
Feb 21, 2023
Member
Author
|
Thanks @thufschmitt for beating me to the reply :) @tomberek I should have made clearer in the PR description that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This functionality was part of
SourceExprCommand. However, it is actually independent parsing installables or source expressions, except for the fact that parsing installables is one of the many things influenced by read-only mode.We can make it a mixin instead, which separates concerns.
Context
Cleaning things up so NixOS/rfcs#134 is easy to implement. We will be surgically separating
InstallableCommandfromSourceExprCommandas part of that, and making those simpler first helps make that task less difficult.Depends on #7754Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*