Scope down --derivation to just the commands that use it#7754
Merged
thufschmitt merged 2 commits intoNixOS:masterfrom Feb 9, 2023
Merged
Scope down --derivation to just the commands that use it#7754thufschmitt merged 2 commits intoNixOS:masterfrom
--derivation to just the commands that use it#7754thufschmitt merged 2 commits intoNixOS:masterfrom
Conversation
It doesn't do anything here, and in the next commit `show-derivation will no longer accept this flag.
Per the old FIXME, this flag was on too many commands, and mostly ignored. Now it is just on the commands where it actually has an effect. Per NixOS#7261, I would still like to get rid of it entirely, but that is a separate project. This change should be good with or without doing that.
7 tasks
thufschmitt
approved these changes
Feb 9, 2023
Member
thufschmitt
left a comment
thufschmitt
left a comment
There was a problem hiding this comment.
Sweet :)
(I'm quite pleased by the fact that this gets naturally statically checked by the fact that operateOn now won't exists at all on the commands that don't use it)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Per the old FIXME, this flag was on too many commands, and mostly ignored. Now it is just on the commands where it actually has an effect.
Previous commit:
Remove
--derivationfrom testIt doesn't do anything here, and in the next commit
show-derivationwill no longer accept this flag.
Context
Per #7261, I would still like to get rid of it entirely, but that is a separate project. This change should be good with or without doing that.
Also working towards NixOS/rfcs#134
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*