Factor out InstallableStorePath to its own file, dedup#7744
Merged
tomberek merged 1 commit intoNixOS:masterfrom Feb 13, 2023
Merged
Factor out InstallableStorePath to its own file, dedup#7744tomberek merged 1 commit intoNixOS:masterfrom
InstallableStorePath to its own file, dedup#7744tomberek merged 1 commit intoNixOS:masterfrom
Conversation
`nix app` had something called `InstallableDerivedPath` which is actually the same thing. We go with the later's name because it has become more correct. I originally did this change (more hurriedly) as part of NixOS#6225 --- a mini store-only Nix and a full Nix need to share this code. In the first RFC meeting for NixOS/rfcs#134 we discussed how some splitting of the massive `installables.cc` could begin prior, as that is a good thing anyways. (@edolstra's words, not mine!) This would be one such PR.
This was referenced Feb 3, 2023
Contributor
|
Would be helpful to have a diagram or some description of the types/sub-types involved. (doxygen?) This might be out of scope for this change, but would be helpful overall.
|
tomberek
approved these changes
Feb 12, 2023
Contributor
tomberek
left a comment
tomberek
left a comment
There was a problem hiding this comment.
- strictly an improvement
- no regressions
Member
Author
|
Thank you @tomberek! Agree Doxygen would be good. I'll try to look into that this upcoming week. |
Member
Author
|
#7814 issue for API docs. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
nix apphad something calledInstallableDerivedPathwhich is actually the same thing. We go with the later's name because it has become more correct.Context
I originally did this change (more hurriedly) as part of #6225 --- a mini store-only Nix and a full Nix need to share this code. In the first RFC meeting for NixOS/rfcs#134 we discussed how some splitting of the massive
installables.cccould begin prior, as that is a good thing anyways. (@edolstra's words, not mine!) This would be one such PR.Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*