Skip to content

[2.13-maintenance] revert addition of property tests#7687

Merged
roberth merged 4 commits intoNixOS:2.13-maintenancefrom
hercules-ci:2.13-maintenance-revert-addition-of-property-tests
Jan 25, 2023
Merged

[2.13-maintenance] revert addition of property tests#7687
roberth merged 4 commits intoNixOS:2.13-maintenancefrom
hercules-ci:2.13-maintenance-revert-addition-of-property-tests

Conversation

@roberth
Copy link
Member

@roberth roberth commented Jan 25, 2023

Motivation

Fix the release branch, and do not introduce dependency in patch release, as requested.

Context

Maintainers: tick if completed or explain if not relevant

  • agreed on idea
  • agreed on implementation strategy
  • tests, as appropriate
    • functional tests - tests/**.sh
    • unit tests - src/*/tests
    • integration tests
  • documentation in the manual
  • code and comments are self-explanatory
  • commit message explains why the change was made
  • new feature or bug fix: updated release notes

This reverts the addition of property tests from commit d111d2e.
@roberth roberth changed the title 2.13 maintenance revert addition of property tests [2.13-maintenance] revert addition of property tests Jan 25, 2023
We've decided against backporting rapidcheck

This reverts commit e60ee9e.
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for taking this off my plate!

@roberth
Copy link
Member Author

roberth commented Jan 25, 2023

Yeah, working to get the release in a good state finally. I shouldn't need to do this, fwiw.

@roberth roberth merged commit da3faaf into NixOS:2.13-maintenance Jan 25, 2023
@roberth
Copy link
Member Author

roberth commented Jan 25, 2023

Finger crossed for a good release branch 😕

@Ericson2314 Ericson2314 mentioned this pull request Jan 25, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants