Conversation
The original `builtins.getContext` test from 1d75729 would have caught this. The problem is that b30be6b adding `builtins.appendContext` modified that test to make it test too much at once, rather than adding a separate test. We now have isolated tests for both functions, and also a property test showing everything put together (in the form of an eta rule for strings with context). This is better coverage and properly reproduces the bug.
We had some local variables left over from the older (more complicated) implementation of this function. They should all be unused, but one wasn't by mistake. Delete them all, and replace the one that was still in use as intended.
roberth
approved these changes
Jan 23, 2023
|
Successfully created backport PR #7666 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixing a bug. Here's how:
We had some local variables left over from the older (more complicated) implementation of this function. They should all be unused, but one wasn't by mistake.
Delete them all, and replace the one that was still in use as intended.
The first commit fixes the test, reproducing the bug. The second commit fixes the bug, with the now-passing test as proof.
Context
Fix #7655
Here is why this wasn't caught before, despite having a test for these functions:
The original
builtins.getContexttest from 1d75729 would have caught this. The problem is that b30be6b addingbuiltins.appendContextmodified that test to make it test too much at once, rather than adding a separate test.We now have isolated tests for both functions, and also a property test showing everything put together (in the form of an eta rule for strings with context). This is better coverage and properly reproduces the bug.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/tests