OutputSpec: Allow all valid output names#7631
Merged
edolstra merged 4 commits intoNixOS:masterfrom Jan 18, 2023
Merged
Conversation
Ericson2314
reviewed
Jan 18, 2023
Ericson2314
reviewed
Jan 18, 2023
Ericson2314
reviewed
Jan 18, 2023
Ericson2314
reviewed
Jan 18, 2023
Comment on lines
+24
to
+25
| // See checkName() for valid output name characters. | ||
| static std::regex regex(R"((\*)|([a-zA-Z\+\-\._\?=]+(,[a-zA-Z\+\-\._\?=]+)*))"); |
Member
There was a problem hiding this comment.
Can be in a future PR, but it would be great for these two to share code so they are automatically in sync. Maybe we could constexpr build the regex from one to just match a single output name used in checkName, for example.
Member
There was a problem hiding this comment.
I've checked the regex and it looks accurate.
roberth
reviewed
Jan 18, 2023
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Good incremental improvement, and CI has passed.
Comment on lines
+24
to
+25
| // See checkName() for valid output name characters. | ||
| static std::regex regex(R"((\*)|([a-zA-Z\+\-\._\?=]+(,[a-zA-Z\+\-\._\?=]+)*))"); |
Member
There was a problem hiding this comment.
I've checked the regex and it looks accurate.
Ericson2314
approved these changes
Jan 18, 2023
|
Successfully created backport PR #7635 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7624.