Use boost small vectors instead of VLAs in the primops#7346
Closed
thufschmitt wants to merge 1 commit intoNixOS:masterfrom
Closed
Use boost small vectors instead of VLAs in the primops#7346thufschmitt wants to merge 1 commit intoNixOS:masterfrom
thufschmitt wants to merge 1 commit intoNixOS:masterfrom
Conversation
VLAs are a dangerous feature, and their usage triggers an undefined behavior since theire size can be zero in some cases. So replace them with `boost::small_vector`s which fit the same goal but are safer. It's also incidentally consistently 1% faster on the benchmarks.
edolstra
approved these changes
Nov 25, 2022
|
Subsumed by #9430, which has been merged. This should be closed. |
Member
Author
|
Indeed, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VLAs are a dangerous feature, and their usage triggers an undefined
behavior since theire size can be zero in some cases.
So replace them with
boost::small_vectors which fit the same goal butare safer.
It's also incidentally consistently 1% faster on the benchmarks.
The optimal static size of the
small_vectorsstill needs to be benchmarked, currently it's only a wild guess (and probably too big).