exportReferencesGraph should build onlydrvs when used with unsafeDiscardOutputsDependency#7339
Draft
aciceri wants to merge 4 commits intoNixOS:masterfrom
Draft
exportReferencesGraph should build onlydrvs when used with unsafeDiscardOutputsDependency#7339aciceri wants to merge 4 commits intoNixOS:masterfrom
exportReferencesGraph should build onlydrvs when used with unsafeDiscardOutputsDependency#7339aciceri wants to merge 4 commits intoNixOS:masterfrom
Conversation
Without it `checkRef foo` would always imply `checkRef foo.drv`
Checking that graph contains `drv` paths but not outputs
aciceri
changed the title
exportReferencesGraph does not workexportReferencesGraph should build onlydrvs when used with unsafeDiscardOutputsDependency
aciceri
commented
Nov 23, 2022
Comment on lines
-25
to
-27
| checkRef input-1 | ||
| checkRef input-1.drv | ||
| checkRef input-2 |
Member
Author
There was a problem hiding this comment.
@Ericson2314 Why had I to remove these two checks? This test should build also outputs even after removing that piece of code, right?
4 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7330 (hopefully)