Follow XDG Base Directory standard by balsoft · Pull Request #5588 · NixOS/nix

balsoft · 2021-11-17T20:50:20Z

XDG Base Directory is a standard for locations for storing various
files. Nix has a few files which seem to fit in the standard, but
currently use a custom location directly in the user's ~, polluting
it:

~/.nix-profile
~/.nix-defexpr
~/.nix-channels

This pull request makes new Nix installations follow the XDG spec and
instead use the following locations:

$XDG_DATA_HOME/nix/profile
$XDG_DATA_HOME/nix/defexpr
$XDG_DATA_HOME/nix/channels

If $XDG_DATA_HOME is not set, it is assumed to be ~/.local/share.

Old locations are preferred if they exist, but for new installations
(or after cleaning the home dir) new, XDG-conformant locations are
used by default.

Closes #1079

Checklist for maintainers

agreed on idea
agreed on implementation strategy
unit tests (no substantial change in behavior)
functional tests (tests/**.sh)~~ (no substantial change in behavior)
documentation in the manual
code and comments are self-explanatory
commit message explains why the change was made
new feature or incompatible change: updated release notes

doc/manual/src/installation/installing-binary.md

kanashimia · 2021-11-17T21:28:23Z

Just as a note - this is a breaking for tooling that relies on this, like nixos-infect

Also this PR is related: #5226

Ericson2314 · 2021-11-17T22:19:36Z

Very excited for this and #5226! Before it was argued that "well, nix channel is getting deprecated anyways", but I agree it is better to do this anyways, it's just a good look 😎.

cab404 · 2021-11-17T22:11:43Z

scripts/install-nix-from-closure.sh

 # shellcheck source=./nix-profile.sh.in
 . "$nix/etc/profile.d/nix.sh"

+NIX_LINK=$HOME/.nix-profile


Why is it called "NIX_LINK", instead of something like NIX_PROFILE_DIR?
That's really a nitpick, but you've asked to read it through)

Because it was named like that in some other place :)

I suppose this is a good opportunity to rename the var.

tests/nix-channel.sh

edolstra · 2021-11-18T10:33:29Z

A few notes:

~/.nix-defexpr and ~/.nix-channels are legacy, so I don't know if we should risk introducing churn/breakage for something that will eventually get replaced anyway. The nix command doesn't use them anymore.
nix profile does use ~/.nix-profile, but maybe we should get rid of that as well and use /nix/var/nix/profiles/default or /nix/var/nix/profiles/per-user/$USER/default directly. The only reason why the ~/.nix-profile indirection exists is to support nix-env --switch-profile, but I don't think anybody uses that, and nix profile has no equivalent command.

balsoft · 2021-11-18T10:41:35Z

I don't know if we should risk introducing churn/breakage for something that will eventually get replaced anyway

Everything will be replaced eventually. I think channels are still going to be here for a while, so it'd be nice to not pollute user's home directories in the meantime.

nix profile does use ~/.nix-profile, but maybe we should get rid of that as well and use /nix/var/nix/profiles/default or /nix/var/nix/profiles/per-user/$USER/default directly.

Sure! #5226 should handle that. I'll help merge the two together if needed.

balsoft · 2021-11-18T14:23:00Z

Note: this PR needs a corresponding nixpkgs change.

scripts/nix-profile.sh.in

SuperSandro2000 · 2021-11-18T17:21:26Z

scripts/nix-profile.sh.in

+        NIX_LINK="$NIX_LINK_NEW"
+    else
+        if [ -e "$NIX_LINK_NEW" ]; then
+            warning="\033[1;35mwarning:\033[0m"


I am not sure if we want to check if the terminal supports those escape sequences but I bet it would be safe to assume it does.

scripts/nix-profile.sh.in

scripts/nix-profile-daemon.sh.in

scripts/install-nix-from-closure.sh

edolstra · 2021-11-18T20:29:09Z

doc/manual/src/command-ref/nix-store.md


 ```console
-$ nix-store -q --graph ~/.nix-profile | dot -Tps > graph.ps
+$ nix-store -q --graph $XDG_DATA_HOME/nix/profile | dot -Tps > graph.ps


Examples shouldn't use XDG_DATA_HOME because it may not be set (it isn't on my system). It's better to just use ~/.local/share/nix/profile in examples since very few people will use something else.

Maybe the same applies to the documentation, since references to $XDG_DATA_HOME/nix/profile are harder to understand than ~/.local/share/nix/profile.

I fully agree for this example here, but for documentation I think it's important to let the people know we're (kinda) following the XDG spec and not just putting things in ~/.local/share.

scripts/nix-profile-daemon.sh.in

Artturin · 2021-11-19T02:54:32Z

* `nix profile` does use `~/.nix-profile`, but maybe we should get rid of that as well and use `/nix/var/nix/profiles/default` or `/nix/var/nix/profiles/per-user/$USER/default` directly. The only reason why the `~/.nix-profile` indirection exists is to support `nix-env --switch-profile`, but I don't think anybody uses that, and `nix profile` has no equivalent command.

please don't get rid of *nix-profile many users depend on it
some of them can be seen with my doc-repos script
https://gist.github.com/450c2c81c1d94adb952bcb6f2da322b1
and even more in github search https://github.com/search?q=.nix-profile&type=code

idea: NixOS/nixpkgs#146515 (comment)

Ref: NixOS/nix#5588

pasqui23 · 2021-11-22T21:46:53Z

Also I would argue that .nix-profile is actually state and it should go somewhere in XDG_STATE_HOME (default: ~/.local/state)

pasqui23 · 2021-11-22T21:48:36Z

doc/manual/src/command-ref/nix-env.md

    expressions from each subscribed channel in this directory.

-  - `~/.nix-profile`\
+  - `$XDG_DATA_HOME/nix/profile`\


Suggested change

- `$XDG_DATA_HOME/nix/profile`\

- `$XDG_STATE_HOME/nix/profile`\

pasqui23 · 2021-11-22T21:48:58Z

doc/manual/src/command-ref/nix-env.md

    symlink points to `prefix/var/nix/profiles/default`. The `PATH`
-    environment variable should include `~/.nix-profile/bin` for the
-    user environment to be visible to the user.
+    environment variable should include `$XDG_DATA_HOME/nix/bin` for


Suggested change

environment variable should include `$XDG_DATA_HOME/nix/bin` for

environment variable should include `$XDG_STATE_HOME/nix/bin` for

pasqui23 · 2021-11-22T21:49:15Z

doc/manual/src/command-ref/nix-env.md


 This operation makes *path* the current profile for the user. That is,
-the symlink `~/.nix-profile` is made to point to *path*.
+the symlink `$XDG_DATA_HOME/nix/profile` (or `~/.nix-profile`, if it


Suggested change

the symlink `$XDG_DATA_HOME/nix/profile` (or `~/.nix-profile`, if it

the symlink `$XDG_STATE_HOME/nix/profile` (or `~/.nix-profile`, if it

pasqui23 · 2021-11-22T21:49:30Z

doc/manual/src/command-ref/nix-env.md

    Location of the Nix profile. Defaults to the target of the symlink
-    `~/.nix-profile`, if it exists, or `/nix/var/nix/profiles/default`
-    otherwise.
+    `~/.nix-profile`, if it exists, or `$XDG_DATA_HOME/nix/profile`,


Suggested change

`~/.nix-profile`, if it exists, or `$XDG_DATA_HOME/nix/profile`,

`~/.nix-profile`, if it exists, or `$XDG_STATE_HOME/nix/profile`,

pasqui23 · 2021-11-22T21:49:45Z

doc/manual/src/command-ref/nix-store.md


 ```console
-$ nix-store -q --graph ~/.nix-profile | dot -Tps > graph.ps
+$ nix-store -q --graph ~/.local/share/nix/profile | dot -Tps > graph.ps


Suggested change

$ nix-store -q --graph ~/.local/share/nix/profile | dot -Tps > graph.ps

$ nix-store -q --graph ~/.local/state/nix/profile | dot -Tps > graph.ps

pasqui23 · 2021-11-22T22:05:12Z

tests/nix-channel.sh

 # Do an install.
 nix-env -i dependencies-top
-[ -e $TEST_HOME/.nix-profile/foobar ]
+[ -e $TEST_HOME/.local/share/nix/profile/foobar ]


Suggested change

[ -e $TEST_HOME/.local/share/nix/profile/foobar ]

[ -e $TEST_HOME/.local/state/nix/profile/foobar ]

pasqui23 · 2021-11-22T22:05:45Z

tests/nix-channel.sh

+ln -s $(readlink $TEST_HOME/.local/share/nix/profile) $TEST_HOME/.nix-profile
+cp -r $TEST_HOME/.local/share/nix/defexpr $TEST_HOME/.nix-defexpr
+cp -r $TEST_HOME/.local/share/nix/channels $TEST_HOME/.nix-channels
+rm -rf $TEST_HOME/.local/share/nix


Suggested change

ln -s $(readlink $TEST_HOME/.local/share/nix/profile) $TEST_HOME/.nix-profile

cp -r $TEST_HOME/.local/share/nix/defexpr $TEST_HOME/.nix-defexpr

cp -r $TEST_HOME/.local/share/nix/channels $TEST_HOME/.nix-channels

rm -rf $TEST_HOME/.local/share/nix

ln -s $(readlink $TEST_HOME/.local/state/nix/profile) $TEST_HOME/.nix-profile

cp -r $TEST_HOME/.local/state/nix/defexpr $TEST_HOME/.nix-defexpr

cp -r $TEST_HOME/.local/state/nix/channels $TEST_HOME/.nix-channels

rm -rf $TEST_HOME/.local/state/nix

pasqui23 · 2021-11-22T22:06:08Z

tests/nix-channel.sh

+# Do an install.
+nix-env -i dependencies-top
+[ -e $TEST_HOME/.nix-profile/foobar ]
+! [ -e $TEST_HOME/.local/share/nix ]


Suggested change

! [ -e $TEST_HOME/.local/share/nix ]

! [ -e $TEST_HOME/.local/state/nix ]

pasqui23 · 2021-11-22T22:06:18Z

tests/user-envs.sh


 mkdir -p $TEST_HOME
 nix-env --switch-profile $profiles/test
+stat $HOME/.local/share/nix/profile


Suggested change

stat $HOME/.local/share/nix/profile

stat $HOME/.local/state/nix/profile

pasqui23 · 2021-11-22T22:06:37Z

tests/user-envs.sh

+rm -rf $HOME/.local/share/nix/defexpr
+mkdir -p $HOME/.local/share/nix
+ln -s $(pwd)/user-envs.nix $HOME/.local/share/nix/defexpr


Suggested change

rm -rf $HOME/.local/share/nix/defexpr

mkdir -p $HOME/.local/share/nix

ln -s $(pwd)/user-envs.nix $HOME/.local/share/nix/defexpr

rm -rf $HOME/.local/state/nix/defexpr

mkdir -p $HOME/.local/state/nix

ln -s $(pwd)/user-envs.nix $HOME/.local/state/nix/defexpr

edolstra · 2021-11-25T13:00:02Z

I hadn't heard of XDG_STATE_HOME. It appears to have been introduced just a few months ago: https://www.reddit.com/r/linux/comments/ny34vs/new_xdg_state_home_in_xdg_base_directory_spec/. It does fill a gap since ~/.local/share always seemed a bit overloaded.

nixos-discourse · 2021-11-25T15:03:39Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-22/16251/1

Ericson2314 · 2021-12-03T03:00:07Z

I agree XDG_STATE_HOME is better.

As to ~/.nix-profile seems pretty clear to me that we should keep it for now, but we can make it optional, since we have good defaults to fall back upon. Even if we did want to get rid of it, I think that should be done in a separate PR as a separate change.

That said, I don't think it needs an XDG equivalent. One can always symlink $XDG_STATE_DIR/nix/profile itself to achieve the same effect, right?

colemickens · 2022-03-08T22:15:39Z

Big +1 on this PR -- .ssh (wontfix) and .mozilla (finally getting worked on after 18 years) are my last two standouts besides nix.

By the way, it seems like PipeWire is using the new XDG state dir, too.

~
❯ ls -al ~/.local/state
total 2
drwx------ 4 cole cole 4 Mar  4 01:53 .
drwxr-xr-x 4 cole cole 4 Nov 26 22:47 ..
drwx------ 3 cole cole 3 Nov 26 22:47 pipewire
drwx------ 2 cole cole 4 Mar  8 13:17 wireplumber

EDIT: Per Artturin on Matrix, volta is also using the state dir.

colemickens · 2022-03-08T22:31:32Z

I don't want to be too greedy, but I'd happily run this on my systems if it were rebased and applied against nixUnstable easily.

Artturin · 2022-03-08T23:02:59Z

rebased and applied @pasqui23 suggestions of switching to $XDG_STATE_HOME
https://github.com/Artturin/nix/commits/rebasedxdg

Ericson2314 · 2022-03-09T01:35:34Z

~~@Artturin perhaps you want to open a fresh PR?~~

balsoft · 2022-03-09T04:41:18Z

Thanks @Artturin , pushed your version here

Ericson2314 · 2022-03-09T05:10:25Z

Oh good! This is better.

Ericson2314 · 2022-03-09T05:46:04Z

src/nix-channel/nix-channel.cc

+            createDirs(getStateDir() + "/nix");
+            channelsList = getStateDir() + "/nix/channels";


Suggested change

createDirs(getStateDir() + "/nix");

channelsList = getStateDir() + "/nix/channels";

auto dir = getStateDir() + "/nix";

createDirs(dir);

channelsList = dir + "/channels";

applied your suggestions in my branch

cole-h · 2023-02-28T19:16:00Z

I think this broke some stuff unintentionally. nix-env doesn't appear to work without the --use-xdg-base-directories flag passed to it in 2.14.0:

^ without --use-xdg-base-directories

^ with --use-xdg-base-directories

balsoft · 2023-02-28T19:21:02Z

Wow, sorry about that. I wonder why the tests passed :/

balsoft · 2023-02-28T19:23:42Z

Actually, do you still have ~/.nix-profile/bin in your $PATH?

Could you check the ~/.nix-profile/bin and see if it contains editorchecker-config?

I can't reproduce this with 2.14.0pre20230213_c205d10 (which does include this PR)

@cole-h

balsoft · 2023-02-28T19:27:36Z

Can't reproduce with 2.14.0 either:

❯ nix shell nix/2.14.0
❯ nix-env --version
nix-env (Nix) 2.14.0
❯ command -v editorconfig-checker
 ✘ 1
❯ nix-env -iA editorconfig-checker -f '<nixpkgs>' -I nixpkgs=flake:np --extra-experimental-features flakes --no-use-xdg-base-directories
installing 'editorconfig-checker-2.7.0'
❯ command -v editorconfig-checker
/home/balsoft/.nix-profile/bin/editorconfig-checker

This is NixOS, so maybe other distros are broken?

cole-h · 2023-02-28T19:29:00Z

I can confirm editorconfig-checker is in ~/.nix-profile/bin, but that directory is NOT in $PATH. Maybe this was another patch in the 2.14 series, I'll see if I can bisect.

I think this is an issue in the install scripts after all. Sorry for the noise 😅

balsoft · 2023-02-28T19:33:26Z

Ah, this might be the problem: https://github.com/NixOS/nix/pull/5588/files#diff-68e663aabb64bc761187fcc02c1e8fc085109072294796a9cd6af4df20205f38R12

If you don't have ~/.nix-profile, the new location will be used. But this doesn't quite make sense for your issue, I would expect it to be broken the other way round :)

cole-h · 2023-02-28T19:48:38Z

For the moment, I plan on putting the fire out with NixOS/nixpkgs#218858 (using nix-shell instead of nix-env) and will continue chasing this down shortly.

EDIT: I haven't tested myself on NixOS, but I reproduced this in an Ubuntu VM and GitHub Actions CI, both of which use the installer scripts, etc.

cole-h · 2023-02-28T23:34:37Z

OK, finished bisecting earlier, and this PR is indeed the culprit:

vin@scadrial ~/w/v/nix ((2384d360)|BISECTING) 48ms> git bisect skip
There are only 'skip'ped commits left to test.
The first bad commit could be any of:
2384d360839e27edb3c928da858ec911415c8b4d
9ebbe35817a7f7becf77d9f0cd76c54d693f6f28
We cannot bisect more!

(where 2384d36 is the actual commit and 9ebbe35 is the merge; I had to skip a few since I was relying on the installer tests action)

Currently in the middle of trying things manually in a VM (which is a bit of a pain, since I'm relying on the installer tests CI stuff to upload the install script and tarball somewhere that I can curl instead of figuring out how to not do that). I hope to have a fix tomorrow (if nobody else has found one by then).

FWIW, directly after installing, these are the PATHs (maybe expected, but figured it wouldn't hurt to know for sure):

2.13.3 PATH: /home/ubuntu/.nix-profile/bin:/nix/var/nix/profiles/default/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/snap/bin
2.14.0 PATH: /home/ubuntu/.local/state/nix/profile/bin:/nix/var/nix/profiles/default/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/snap/bin

full bisect log

git bisect start
# status: waiting for both good and bad commits
# good: [9bf0baa7f4719aa577ee366aeb3e641e6d755f8f] Bump version
git bisect good 9bf0baa7f4719aa577ee366aeb3e641e6d755f8f
# status: waiting for bad commit, 1 good commit known
# bad: [71a619642d634438cde1db6c545cf1d01bc29aa5] Bump version
git bisect bad 71a619642d634438cde1db6c545cf1d01bc29aa5
# good: [deb35c84b30b257fd9ffa4f4450d4d73a35bbdc9] Merge pull request #7612 from edolstra/release-notes
git bisect good deb35c84b30b257fd9ffa4f4450d4d73a35bbdc9
# good: [0d73313c55497f32dcff1546f0f0625391f7a833] Merge pull request #7318 from fricklerhandwerk/doc-instantiate
git bisect good 0d73313c55497f32dcff1546f0f0625391f7a833
# bad: [707ba52f2d1855f2613da3a576488f5040843915] Merge pull request #7830 from yorickvP/fix-writable-etc
git bisect bad 707ba52f2d1855f2613da3a576488f5040843915
# good: [5597d68e2d73a3b89ff36fcfeac82d7fe7d4f384] Merge pull request #7754 from obsidiansystems/narrower-scope-derivation-flag
git bisect good 5597d68e2d73a3b89ff36fcfeac82d7fe7d4f384
# bad: [c18456604601dd233be4ad2462474488ef8f87e3] Merge pull request #7797 from hercules-ci/tests-set-ps4
git bisect bad c18456604601dd233be4ad2462474488ef8f87e3
# good: [bffb76264ee24611de17d4ecf3fb8b625a564652] Merge pull request #7800 from PicoGeyer/patch-1
git bisect good bffb76264ee24611de17d4ecf3fb8b625a564652
# skip: [a21405a4e8a5ca4bfbe8df8de2f76d69c4608a9f] Add regression test
git bisect skip a21405a4e8a5ca4bfbe8df8de2f76d69c4608a9f
# bad: [67451d8ed797d1bd5fb69f6218ea686761ad13b0] Merge pull request #7802 from edolstra/fix-7783
git bisect bad 67451d8ed797d1bd5fb69f6218ea686761ad13b0
# skip: [c49b7472eaa7a6501aa937b40f80702ecf0f43e6] Fix macOS build
git bisect skip c49b7472eaa7a6501aa937b40f80702ecf0f43e6
# bad: [9ebbe35817a7f7becf77d9f0cd76c54d693f6f28] Merge pull request #5588 from tweag/balsoft/xdg
git bisect bad 9ebbe35817a7f7becf77d9f0cd76c54d693f6f28
# skip: [2384d360839e27edb3c928da858ec911415c8b4d] A setting to follow XDG Base Directory standard
git bisect skip 2384d360839e27edb3c928da858ec911415c8b4d
# only skipped commits left to test
# possible first bad commit: [9ebbe35817a7f7becf77d9f0cd76c54d693f6f28] Merge pull request #5588 from tweag/balsoft/xdg
# possible first bad commit: [2384d360839e27edb3c928da858ec911415c8b4d] A setting to follow XDG Base Directory standard

cole-h · 2023-03-01T00:24:38Z

Maybe-not-perfect fix is up: #7925

mikeland73

When XDG is not set, we set
NIX_LINK_NEW=$HOME/.local/state/nix/profile

but I think it should be

NIX_LINK_NEW=$HOME/.local/state/nix/profiles/profile/ ?

(at least that seems to be where nix is creating profile symlink in 2.14.0)

mikeland73 · 2023-03-01T00:39:54Z

scripts/nix-profile-daemon.sh.in

+if [ -n "$XDG_STATE_HOME" ]; then
+    NIX_LINK_NEW="$XDG_STATE_HOME/nix/profile"
+else
+    NIX_LINK_NEW=$HOME/.local/state/nix/profile


Should this be NIX_LINK_NEW=$HOME/.local/state/nix/profiles/profile/ ?

What does make you think we want to profile/profiles? That looks like a bug to me.

@SuperSandro2000 I'm not familiar with the nix source code, but when I do a single user install on a fresh docker ubuntu, nix adds the following sym link:

~/.nix-profile -> ~/.local/state/nix/profiles/profile

Do we not want this value to match that?

If ~/.nix-profile doesn't exist and $XDG_STATE_HOME is not set, we end up with NIX_LINK_NEW=$HOME/.local/state/nix/profile but this link target doesn't exist on my install.

It seems like there is both ~/.local/share/nix/profiles/profile and ~/.local/state/nix/profile. The former is the actual profile, the latter is a symlink to it. I think this should be simplified by putting the profiles in state and removing the useless indirection (compatibility is only needed for ~/.nix-profile when not using xdg-base-dirs)

(Or keep the profiles in share, we've had enough breakage already)

Yes this is what I called out in #5588 (comment). I think rather than trying to support 4(!) combinations, we should do all the XDG stuff (this and home directories) together so there are just 2 combinations.

ncfavier · 2023-03-01T09:19:18Z

Another seemingly related failure in home-manager even after bumping install-nix-action to v20:

error: opening lock file '/nix/var/nix/profiles/per-user/runner/home-manager.lock': No such file or directory

balsoft · 2023-03-01T10:06:08Z

@ncfavier I think that might be more related to #5226

nixos-discourse · 2023-03-16T12:43:31Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1

asymmetric · 2023-03-16T15:14:27Z

For those wondering, this landed in 2.14.0.

balsoft · 2023-03-16T15:45:44Z

2.14.0 is still broken (although now for different reasons). The current installed still points to 2.13.3.

nixos-discourse · 2023-04-21T11:57:40Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nix-team-report-2022-10-2023-03/27486/1

nixos-discourse · 2024-03-26T17:18:35Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/intentional-side-effects-of-package-installation/42224/3

balsoft mentioned this pull request Nov 17, 2021

Does nix has a plan to comply with XDG Base Directory Spec? #1079

Closed

jtojnar reviewed Nov 17, 2021

View reviewed changes

doc/manual/src/installation/installing-binary.md Outdated Show resolved Hide resolved

cab404 reviewed Nov 17, 2021

View reviewed changes

balsoft force-pushed the balsoft/xdg branch from ba0cce9 to 3d2b5a4 Compare November 18, 2021 10:02

SuperSandro2000 reviewed Nov 18, 2021

View reviewed changes

scripts/nix-profile.sh.in Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Nov 18, 2021

View reviewed changes

balsoft mentioned this pull request Nov 18, 2021

Support XDG-conformant paths for internal Nix files NixOS/nixpkgs#146515

Draft

12 tasks

edolstra reviewed Nov 18, 2021

View reviewed changes

balsoft added a commit to tweag/nixpkgs that referenced this pull request Nov 22, 2021

Support XDG-conformant locations for the nix defexpr

2ff1ea6

Ref: NixOS/nix#5588

pasqui23 suggested changes Nov 22, 2021

View reviewed changes

balsoft force-pushed the balsoft/xdg branch from 688210a to b178cc0 Compare March 9, 2022 04:41

balsoft force-pushed the balsoft/xdg branch from b178cc0 to 5c42528 Compare March 9, 2022 04:42

Ericson2314 reviewed Mar 9, 2022

View reviewed changes

cole-h mentioned this pull request Feb 28, 2023

Fixup editorconfig action with Nix 2.14.0 NixOS/nixpkgs#218858

Merged

12 tasks

cole-h mentioned this pull request Mar 1, 2023

Check if NIX_LINK_NEW exists instead of checking that NIX_LINK doesn't exist #7925

Merged

7 tasks

mikeland73 reviewed Mar 1, 2023

View reviewed changes

balsoft mentioned this pull request Mar 1, 2023

Handle use-xdg-base-directories for profile link #7929

Closed

7 tasks

abathur mentioned this pull request Mar 1, 2023

Issue with Installing Nix After MacOS Update (Nix stopped working) #7880

Open

3 tasks

Ericson2314 mentioned this pull request Mar 21, 2023

Fix nix profile --help #8078

Merged

7 tasks

SharzyL mentioned this pull request Apr 14, 2023

bug: Hm hardcodes the Nix profile path nix-community/home-manager#2544

Closed

1 task

utkarshgupta137 mentioned this pull request Apr 14, 2023

home: fix profileDirectory if use-xdg-base-directories nix-community/home-manager#3876

Merged

7 tasks

thufschmitt mentioned this pull request May 17, 2023

Expanding tests and docs relating to deleting profiles #8351

Merged

8 tasks

infinisil mentioned this pull request May 22, 2023

nix: 2.13.3 -> 2.15.1 NixOS/nixpkgs#233439

Merged

12 tasks

abathur mentioned this pull request Jun 24, 2023

nix-profile-daemon.fish and nix-profile.fish do not support use-xdg-base-directories setting #8573

Open

midchildan mentioned this pull request Aug 7, 2023

nix: add a declarative alternative to Nix channels nix-community/home-manager#4031

Merged

5 tasks

wh0 mentioned this pull request Dec 29, 2023

nix-profile: fix both profile links detection #9590

Merged

PedroRegisPOAR mentioned this pull request Mar 12, 2024

The nix (Nix) 2.21.0pre20240222_6a5210f statically compiled is not able to install packages in profile #6976

Open

	- `$XDG_DATA_HOME/nix/profile`\
	- `$XDG_STATE_HOME/nix/profile`\

	environment variable should include `$XDG_DATA_HOME/nix/bin` for
	environment variable should include `$XDG_STATE_HOME/nix/bin` for

	the symlink `$XDG_DATA_HOME/nix/profile` (or `~/.nix-profile`, if it
	the symlink `$XDG_STATE_HOME/nix/profile` (or `~/.nix-profile`, if it

	`~/.nix-profile`, if it exists, or `$XDG_DATA_HOME/nix/profile`,
	`~/.nix-profile`, if it exists, or `$XDG_STATE_HOME/nix/profile`,

	$ nix-store -q --graph ~/.local/share/nix/profile \| dot -Tps > graph.ps
	$ nix-store -q --graph ~/.local/state/nix/profile \| dot -Tps > graph.ps

	[ -e $TEST_HOME/.local/share/nix/profile/foobar ]
	[ -e $TEST_HOME/.local/state/nix/profile/foobar ]

	! [ -e $TEST_HOME/.local/share/nix ]
	! [ -e $TEST_HOME/.local/state/nix ]

	stat $HOME/.local/share/nix/profile
	stat $HOME/.local/state/nix/profile

		createDirs(getStateDir() + "/nix");
		channelsList = getStateDir() + "/nix/channels";

-            createDirs(getStateDir() + "/nix");
-            channelsList = getStateDir() + "/nix/channels";
+            auto dir = getStateDir() + "/nix";
+            createDirs(dir);
+            channelsList = dir + "/channels";

Uh oh!

Conversation

balsoft commented Nov 17, 2021 • edited by fricklerhandwerk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist for maintainers

Uh oh!

Uh oh!

kanashimia commented Nov 17, 2021

Uh oh!

Ericson2314 commented Nov 17, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

edolstra commented Nov 18, 2021

Uh oh!

balsoft commented Nov 18, 2021

Uh oh!

balsoft commented Nov 18, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Artturin commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pasqui23 commented Nov 22, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edolstra commented Nov 25, 2021

Uh oh!

nixos-discourse commented Nov 25, 2021

Uh oh!

Ericson2314 commented Dec 3, 2021

Uh oh!

colemickens commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

colemickens commented Mar 8, 2022

Uh oh!

Artturin commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ericson2314 commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balsoft commented Mar 9, 2022

Uh oh!

Ericson2314 commented Mar 9, 2022

balsoft commented Nov 17, 2021 •

edited by fricklerhandwerk

Loading

Artturin commented Nov 19, 2021 •

edited

Loading

colemickens commented Mar 8, 2022 •

edited

Loading

Artturin commented Mar 8, 2022 •

edited

Loading

Ericson2314 commented Mar 9, 2022 •

edited

Loading

Ericson2314 Mar 9, 2022 •

edited

Loading

balsoft commented Feb 28, 2023 •

edited

Loading

balsoft commented Feb 28, 2023 •

edited

Loading

cole-h commented Feb 28, 2023 •

edited

Loading

ncfavier Mar 3, 2023 •

edited

Loading