Merged
Conversation
This fixes a class of crashes and introduces ptr<T> to make the code robust against this failure mode going forward. Thanks regnat for the idea of a ref<T> without overhead! Closes NixOS#4895 Closes NixOS#4893 Closes NixOS#5127 Closes NixOS#5113
This was referenced Aug 29, 2021
fogti
reviewed
Aug 29, 2021
Contributor
|
comparisons between positions and |
Member
Author
That would be nice, but doing so has the potential to change the behavior. I'd like to keep that to a minimum so this can be merged sooner rather than later. DetailsIt's just not that simple. `Pos::operator bool()` seems like an obvious candidate, but on closer inspection, flake.cc initializes it with a `file` but `line = 0`. Could it be changed? Yes. Should it? Probably. Does it help with the release? No. |
Member
|
@roberth Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a class of crashes and introduces
ptr<T>to make thecode robust against this failure mode going forward.
Thanks regnat for the idea of a
ref<T>without overhead! This becameptr<T>Closes #4895
Closes #4893
Closes #5127
Closes #5113
Alternatives considered:
&Pos: not mutable, so doesn't fit the current usage patternref<Pos>: undue overheadnoPosand usenullptrinstead. This is fragile. Same foroptional, which doesn't prevent this problem at compile time.