Conversation
thufschmitt
added
ca-derivations
thufschmitt
force-pushed
the
ca/sign-drvoutputs
branch
from
a250fad to
d3ebc96
Compare
Ericson2314
approved these changes
Mar 10, 2021
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Did just a quick read through, but looks good.
Not exposed anywhere, but built realisations are now signed (and this should be forwarded when copy-ing them around)
I guess the rationale behind the old name wath that `pathInfoIsTrusted(info)` returns `true` iff we would need to `blindly` trust the path (because it has no valid signature and `requireSigs` is set), but I find it to be a really confusing footgun because it's quite natural to give it the opposite meaning.
Don't let them inherit the signature from the parent one (because it makes no sense to do so), but re-sign them after they have been built
thufschmitt
force-pushed
the
ca/sign-drvoutputs
branch
from
d3ebc96 to
703c98c
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
signaturefield to the derivation outputs, and sign them (the same way we sign path-infos/nars).Fix #4248