Closed
Conversation
thufschmitt
force-pushed
the
terminal-ca-derivations
branch
from
0b4d3c3 to
f6654ce
Compare
Member
|
It will probably be another day or two before I can properly read this, sorry. |
thufschmitt
force-pushed
the
terminal-ca-derivations
branch
from
f6654ce to
0d6953d
Compare
Move the logic from the `nix make-content-addressed` nix command to a new method in the `Store` class
This is required so that we can call LocalStore::makeContentAddressed on paths that haven't been registered
Very limited atm: - Only `nix-build` works properly (`nix-store`, `nix build`, etc.. will print and create a symlink to a non-existent output path) - It isn't possible to depend on a content-addressed derivation
Otherwise `resolveDerivation` changes the name of the derivation (and as a consequence its hash)
thufschmitt
force-pushed
the
terminal-ca-derivations
branch
from
0d6953d to
c89ab8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First very limited support:
nix-buildworks properly with CA derivations (nix-store,nix build, etc.. will print and create a symlink to a non-existent output path)Mostly taken out of #3528 with some changes to reuse the logic already in
nix/make-content-addressable.cc.Builds on top of #3678
/cc @edolstra @Ericson2314