libutil/union-source-accessor: Barf on non-existent directories#14961
Merged
libutil/union-source-accessor: Barf on non-existent directories#14961
Conversation
Previously builtins.readDir would return an empty attribute set instead of barfing on non-existent paths. This is a regression from 2.32 for impure eval.
xokdvium
added
backport 2.32-maintenance
github-actions
bot
added
the
with-tests
Contributor
Author
|
Might make sense to backport further since it was also broken with a relocated store (that's when the union accessor was used prior to 2.32). |
Ericson2314
approved these changes
Jan 10, 2026
|
Successfully created backport PR for |
|
Successfully created backport PR for |
JustAGuyTryingHisBest
pushed a commit
to JustAGuyTryingHisBest/nix
that referenced
this pull request
Jan 12, 2026
libutil/union-source-accessor: Barf on non-existent directories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously
builtins.readDirwould return an empty attribute set instead of barfing on non-existent paths. This is a regression from 2.32 for impure eval.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.