libutil: Print stack trace on assertion failure#14194
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Oct 11, 2025
Merged
libutil: Print stack trace on assertion failure#14194Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
xokdvium
force-pushed
the
stacktrace-assertion
branch
from
04d9d72 to
3508fe8
Compare
This change overrides __assert_fail on glibc/musl to instead call std::terminate that we have a custom handler for. This ensures that we have more context to diagnose issues encountered by users in the wild.
xokdvium
force-pushed
the
stacktrace-assertion
branch
from
3508fe8 to
46382ad
Compare
Ericson2314
approved these changes
Oct 10, 2025
xokdvium
added
backport 2.31-maintenance
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.31-maintenance
git worktree add -d .worktree/backport-14194-to-2.31-maintenance origin/2.31-maintenance
cd .worktree/backport-14194-to-2.31-maintenance
git switch --create backport-14194-to-2.31-maintenance
git cherry-pick -x 46382ade74bdd811ddeab7da33d57effaa76852a |
|
Successfully created backport PR for |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This change overrides
__assert_failon glibc/muslto instead call std::terminate that we have a custom handler for. This ensures that we have more context to diagnose issues encountered by users in the wild.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.