Address ifdef problem with macOS/BSD sandboxing#13455
Merged
xokdvium merged 2 commits intoNixOS:masterfrom Jul 11, 2025
Merged
Conversation
This works around the macOS issue that the prior commit addresses.
gustavderdrache
force-pushed
the
gustavderdrache/fix-sandbox-ifdef
branch
from
0f65596 to
8e5814d
Compare
Contributor
Author
|
I've had to roll the version back in CI to work around the macOS build failures. Once a release includes this fix, it should no longer be necessary. |
Contributor
|
This the source of failures in e.g. https://github.com/NixOS/nix/actions/runs/16229846793/job/45831922554, right? |
Contributor
Author
|
Yeah. We've had to roll our installer back for the same reason. |
xokdvium
approved these changes
Jul 11, 2025
xokdvium
added
the
backport 2.30-maintenance
13 tasks
edolstra
added a commit
that referenced
this pull request
Jul 12, 2025
…3455 Address ifdef problem with macOS/BSD sandboxing (backport #13455)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses an issue we identified for macOS users. The
#ifdefcondition seems impossible, and causes some (but not all) builds to fail.Based on
git bisecting, it looks like this was introduced in #13281.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.