Skip to content

Unexpose config headers (low hanging fruit only) (backport #12773)#12780

Closed
mergify[bot] wants to merge 1 commit into2.27-maintenancefrom
mergify/bp/2.27-maintenance/pr-12773
Closed

Unexpose config headers (low hanging fruit only) (backport #12773)#12780
mergify[bot] wants to merge 1 commit into2.27-maintenancefrom
mergify/bp/2.27-maintenance/pr-12773

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2025

  • Some headers were completely redundant and have been removed.
  • Other headers have been turned private.
  • Unnecessary meson.build code has been removed.
  • libutil-tests now has a private config header, where previously it had none. This removes the need to expose a package version macro publicly.

I've left a few comments about usage as a public header. It doesn't seem like all that many places.

Motivation

Context

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This is an automatic backport of pull request #12773 done by [Mergify](https://mergify.com).

@roberth @mergify
Unexpose config headers (low hanging fruit only)
fa21aaa 
- Some headers were completely redundant and have been removed.
- Other headers have been turned private.
- Unnecessary meson.build code has been removed.
- libutil-tests now has a private config header, where previously
  it had none. This removes the need to expose a package version
  macro publicly.

(cherry picked from commit b86a760)
@mergify mergify bot added automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue labels Mar 28, 2025
@mergify mergify bot requested review from Ericson2314 and edolstra as code owners March 28, 2025 16:45
@github-actions github-actions bot added new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority c api Nix as a C library with a stable interface labels Mar 28, 2025
@Ericson2314
Copy link
Member

Ericson2314 commented Mar 28, 2025

@Mergifyio queue

@mergify
Copy link
Contributor Author

mergify bot commented Mar 28, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Details

Pull request #12780 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

mergify bot added a commit that referenced this pull request Mar 28, 2025
@mergify
Merge of #12780
1174eac
@mergify mergify bot mentioned this pull request Mar 28, 2025
Closed
37 tasks
@edolstra
Copy link
Member

edolstra commented Mar 28, 2025

Not sure that this should be backported since it's not really a bug fix (?) and code churn in maintenance branches should be kept to a minimum.

@edolstra
Copy link
Member

edolstra commented Mar 28, 2025

@Mergifyio dequeue

@mergify
Copy link
Contributor Author

mergify bot commented Mar 28, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #12780 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify
Copy link
Contributor Author

mergify bot commented Mar 28, 2025

dequeue

✅ The pull request has been removed from the queue default

This was referenced Mar 29, 2025
Merged
Merged
@Mic92 Mic92 closed this Mar 31, 2025
@Mic92 Mic92 deleted the mergify/bp/2.27-maintenance/pr-12773 branch March 31, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees

No one assigned

Labels

automatic backport This PR is a backport produced by automation (does not trigger backporting) c api Nix as a C library with a stable interface new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ericson2314 @edolstra @Mic92 @roberth