Unexpose config headers (low hanging fruit only)#12773
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Mar 28, 2025
Merged
Unexpose config headers (low hanging fruit only)#12773Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
- Some headers were completely redundant and have been removed. - Other headers have been turned private. - Unnecessary meson.build code has been removed. - libutil-tests now has a private config header, where previously it had none. This removes the need to expose a package version macro publicly.
github-actions
bot
added
new-cli
This was referenced Mar 28, 2025
mergify bot
added a commit
that referenced
this pull request
Mar 28, 2025
…2773 Unexpose config headers (low hanging fruit only) (backport #12773)
Ericson2314
added a commit
that referenced
this pull request
Mar 31, 2025
Ericson2314
added
the
backport 2.28-maintenance
mergify bot
added a commit
that referenced
this pull request
Mar 31, 2025
…2773 Unexpose config headers (low hanging fruit only) (backport #12773)
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've left a few comments about usage as a public header. It doesn't seem like all that many places.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.