Imply --offline during tab completion#12595
Open
edolstra wants to merge 4 commits intoNixOS:masterfrom
Open
Conversation
Previously, if you don't have Internet connectivity, tab completion might try to fetch the flake registry, e.g. $ NIX_GET_COMPLETIONS=4 nix build -vvvvv --offline /home/eelco/De evaluating file '<nix/derivation-internal.nix>' downloading 'https://channels.nixos.org/flake-registry.json'... warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; retrying in 294 ms warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; retrying in 541 ms warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; retrying in 1230 ms warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; retrying in 2285 ms warning: error: unable to download 'https://channels.nixos.org/flake-registry.json': Could not resolve hostname (6) Could not resolve host: channels.nixos.org; using cached version
Member
|
This doesn't look like a sustainable strategy for dealing with options. We're going to need some serious diagrams to model how all these values come to be, once things get serious (e.g. something like a repeat #11079 but different) What if instead we
Also cc @Ericson2314 |
Mic92
reviewed
Mar 7, 2025
| { | ||
| // FIXME: should check for command line overrides only. | ||
| if (!settings.useSubstitutes.overridden) | ||
| settings.useSubstitutes = false; |
Member
There was a problem hiding this comment.
@roberth so your idea would be to have useSubstitute, tarballTtl, fileTransfersettings etc check in their getters if we are in offline mode or NIX_COMPLETIONS is set?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, if you don't have Internet connectivity, tab completion might try to fetch the flake registry, e.g.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.