Restore detailed Nix CLI version#12498
Merged
Ericson2314 merged 3 commits intomasterfrom Feb 18, 2025
Merged
Conversation
... as intended.
Requirements:
- don't build fresh libraries for each git commit
- have git commit in the CLI
Bug:
- echo ${version} went into the wrong file => use the fact that it's
a symlink, not just for reading but also for writing.
roberth
added
build-problem
roberth
commented
Feb 18, 2025
| # Symlink ./.version points there, but by default only workDir is writable. | ||
| '' | ||
| chmod u+w ./.version | ||
| echo ${version} > ../../../.version |
Member
Author
There was a problem hiding this comment.
The bad target.
I'll apply this change to all components.
This way it's easier to get right. See previous commit.
github-actions
bot
added
with-tests
edolstra
reviewed
Feb 18, 2025
edolstra
approved these changes
Feb 18, 2025
Ericson2314
approved these changes
Feb 18, 2025
This was referenced Feb 18, 2025
mergify bot
added a commit
that referenced
this pull request
Feb 19, 2025
…2498 Restore detailed Nix CLI version (backport #12498)
ztzg
reviewed
Mar 4, 2025
|
|
||
| setVersionLayer = finalAttrs: prevAttrs: { | ||
| preConfigure = | ||
| prevAttrs.prevAttrs or "" |
Contributor
There was a problem hiding this comment.
I believe this should be prevAttrs.preConfigure.
roberth
added a commit
to roberth/nix
that referenced
this pull request
Mar 4, 2025
Apparently dead code in our use case, but good to keep nonetheless. Credit: ztzg in NixOS#12498 (review)
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
Apparently dead code in our use case, but good to keep nonetheless. Credit: ztzg in #12498 (review) (cherry picked from commit dcaea8c)
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
Apparently dead code in our use case, but good to keep nonetheless. Credit: ztzg in #12498 (review) (cherry picked from commit dcaea8c)
This was referenced Mar 4, 2025
L-as
pushed a commit
to L-as/nix
that referenced
this pull request
Mar 11, 2025
Apparently dead code in our use case, but good to keep nonetheless. Credit: ztzg in NixOS#12498 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as intended.
Requirements:
Bug:
echo ${version}went into the wrong file=> use the fact that it's a symlink, not just for reading but also for writing.
Motivation
Context
Review commit by commit
Refines the implementation of Rewrite build system in Meson #2503
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.