Add SSHMaster::Connection::trySetBufferSize (backport #10765)#12485
Merged
Ericson2314 merged 2 commits into2.26-maintenancefrom Feb 17, 2025
Merged
Add SSHMaster::Connection::trySetBufferSize (backport #10765)#12485Ericson2314 merged 2 commits into2.26-maintenancefrom
SSHMaster::Connection::trySetBufferSize (backport #10765)#12485Ericson2314 merged 2 commits into2.26-maintenancefrom
Conversation
It is unused in Nix currently, but will be used in Hydra. This reflects what Hydra does in NixOS/hydra#1387. We may probably to use it more widely for better SSH store performance, but this needs to be subject to more testing before we do that. (cherry picked from commit 0d25cc6)
Exposed for Hydra. We could make it fancier but with (a) new store settings (b) switch to `ssh-ng://` both in the works, it doesn't seem worth it. (cherry picked from commit 94a7c34)
mergify
bot
added
automatic backport
github-actions
bot
added
the
store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It is unused in Nix currently, but will be used in Hydra. This reflects what Hydra does in NixOS/hydra#1387.
Context
We may probably to use it more widely for better SSH store performance, but this needs to be subject to more testing before we do that.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #10765 done by [Mergify](https://mergify.com).