Ignore local registries for lock file generation#12019
Closed
edolstra wants to merge 2 commits intoNixOS:masterfrom
Closed
Ignore local registries for lock file generation#12019edolstra wants to merge 2 commits intoNixOS:masterfrom
edolstra wants to merge 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
documentation
fetching
When resolving indirect flake references like `nixpkgs` in `flake.nix` files, Nix will no longer use the system and user flake registries. It will only use the global flake registry and overrides given on the command line via `--override-flake`.
edolstra
force-pushed
the
ignore-local-registries
branch
from
0b27c4f to
be49fe3
Compare
Contributor
|
The local registry would then only be used to resolve flake references in cli args? |
Member
Author
|
@elikoga Yes, that's right. |
roberth
reviewed
Dec 9, 2024
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
This looks fairly straightforward, but I expect this behavior to be documented.
Also a test would be good.
Member
Author
|
Added some docs. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Member
Author
|
Merged via #12068. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When resolving indirect flake references like
nixpkgsinflake.nixfiles, Nix will no longer use the system and user flake registries. It will only use the global flake registry and overrides given on the command line via--override-flake.This avoids accidents where users have local registry overrides that map
nixpkgsto apath:flake in the local file system, which then end up in committed lock files pushed to other users.Fixes #12010.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.