mk: add support for passing LDFLAGS to libs and bins#1201
Closed
trofi wants to merge 1 commit intoNixOS:masterfrom
trofi:master
Closed
mk: add support for passing LDFLAGS to libs and bins#1201trofi wants to merge 1 commit intoNixOS:masterfrom trofi:master
trofi wants to merge 1 commit intoNixOS:masterfrom
trofi:master
Conversation
autotools-based systems usually allow user to
append own LDFLAGS like
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
at ./configure stage
This change plumbs LDFLAGS through similar to existing CXXFLAGS variable.
Signed-off-by: Sergei Trofimovich <[email protected]>
Member
|
What about |
Contributor
Author
|
File I basically looked at all uses of |
Member
|
Cc @edolstra |
puffnfresh
approved these changes
Aug 2, 2017
Member
puffnfresh
left a comment
puffnfresh
left a comment
There was a problem hiding this comment.
Thanks! I need this to compile Nix under Termux.
Contributor
Author
|
ping :) |
Contributor
|
Very useful; hopefully subsumed by #2979 |
Contributor
Author
|
Yeah, looks like the change was applied as-is as fe068ec. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autotools-based systems usually allow user to
append own LDFLAGS like
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
at ./configure stage
This change plumbs LDFLAGS through similar to existing CXXFLAGS variable.
Signed-off-by: Sergei Trofimovich [email protected]