Skip to content

Comments

Remove old make (attempt 2)#11850

Merged
edolstra merged 1 commit intoNixOS:masterfrom
DeterminateSystems:remove-old-make-attempt-2
Nov 11, 2024
Merged

Remove old make (attempt 2)#11850
edolstra merged 1 commit intoNixOS:masterfrom
DeterminateSystems:remove-old-make-attempt-2

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Nov 11, 2024

Motivation

Reverts the revert in #11826 now that we've branched Nix 2.25.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@edolstra
Revert "Merge pull request NixOS#11826 from DeterminateSystems/revert…
f29e786 
…-11804"

This reverts commit aeffdef, reversing
changes made to 723fdeb.
@github-actions github-actions bot added documentation new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority store Issues and pull requests concerning the Nix store fetching Networking with the outside (non-Nix) world, input locking c api Nix as a C library with a stable interface labels Nov 11, 2024
@Ericson2314
Copy link
Member

Ericson2314 commented Nov 11, 2024

Thank you!

@edolstra edolstra enabled auto-merge November 11, 2024 16:10
@edolstra edolstra merged commit 200f45e into NixOS:master Nov 11, 2024
@edolstra edolstra deleted the remove-old-make-attempt-2 branch November 11, 2024 16:52
@nixos-discourse
Copy link

nixos-discourse commented Nov 11, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-11-06-nix-team-meeting-minutes-192/55847/3

@goyalyashpal goyalyashpal mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

Assignees

No one assigned

Labels

c api Nix as a C library with a stable interface documentation fetching Networking with the outside (non-Nix) world, input locking new-cli Relating to the "nix" command store Issues and pull requests concerning the Nix store with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edolstra @Ericson2314 @nixos-discourse