Revert "Merge pull request #11804 from obsidiansystems/remove-old-make"#11826
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Nov 8, 2024
Merged
Revert "Merge pull request #11804 from obsidiansystems/remove-old-make"#11826Mic92 merged 1 commit intoNixOS:masterfrom
Mic92 merged 1 commit intoNixOS:masterfrom
Conversation
edolstra
requested review from
Ericson2314 and
fricklerhandwerk
as code owners
github-actions
bot
added
documentation
new-cli
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
edolstra
added a commit
to DeterminateSystems/nix-src
that referenced
this pull request
Nov 11, 2024
This was referenced Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Annoying I know, but we should have at least one release cycle where the new build system is feature-complete before removing the old one. A bit of soak time allows resolving issues like:
ninjaBuildPhase34 seconds slower thanbuildPhasewith the old build system? (Might be because it's building the API docs by default, or because it's building the tests, which ideally would be done onninjaCheckPhaseonly.)ninjaBuildPhaseto spit out a huge amount of warnings on every incremental build.ninjaCheckPhase(ninjaCheckPhase hangs in flakes/develop test #11827).nixpackage.packages.x86_64-linuxcontains 293 packages (which is a UX problem in itself), but not the one you would expect... (Flakenixpackage #11822)So I would suggest we branch off 2.25 soon and then revert this revert. Alternatively we can branch off 2.25 and apply this revert to that branch.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.