Merged
Conversation
It had gotten rather big. Hopefully we'll eventually have some generic infra for a "multi-package dev shell" and not need so much code for this, but until then it's better in a separate file.
We have per-stdenv package sets, so we should be using them.
When we get rid of the make build system, we would be missing things. Incuding these packages' deps ensure we don't miss things.
roberth
approved these changes
Nov 5, 2024
| ; | ||
| }); | ||
| in | ||
| makeShell = import ./packaging/dev-shell.nix { inherit lib devFlake; }; |
Member
There was a problem hiding this comment.
callPackage might be nice, but also a bigger change.
| (pkgs.nix.override { forDevShell = true; }).overrideAttrs (attrs: | ||
|
|
||
| let | ||
| stdenv = pkgs.nixDependencies.stdenv; |
Member
There was a problem hiding this comment.
If the shell were part of nixComponents, this would just be a stdenv parameter and it all works out.
`lib.concatMapAttrs` instead of `lib.mapAttrs'` and `lib.nameValuePair` Co-authored-by: Robert Hensing <[email protected]>
Member
Author
|
Applied the one suggestion, happy to keep reworking things re the others. Just wanted to do enough to unblock the full Meson switchover PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
These are good in general, but in particular (except for the code motion) are needed before we drop the old make build system.
Context
#2503
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.