Skip to content

Comments

Remove unused operator<=>'s that darwin can't generate#11091

Merged
edolstra merged 1 commit intomasterfrom
darwin-no-map-spaceship
Jul 12, 2024
Merged

Remove unused operator<=>'s that darwin can't generate#11091
edolstra merged 1 commit intomasterfrom
darwin-no-map-spaceship

Conversation

@roberth
Copy link
Member

@roberth roberth commented Jul 12, 2024

Motivation

It was complaining a lot, with dozens of MB of logs.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

It was complaining *a lot*, with dozens of MB of logs.
@roberth roberth requested a review from Ericson2314 as a code owner July 12, 2024 15:50
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make Darwin generate them instead somehow? Because #10838 needs a fix for that, and if we can solve it for this, then we might as well keep these for testing.

(I thought they were already needed for testing!)

@roberth
Copy link
Member Author

roberth commented Jul 12, 2024

Can we make Darwin generate them instead somehow?

It doesn't have a <=> for std::map. I don't see how we could affect that, except requiring newer dependencies, if they even implement that.

This is easy enough to revert, or re-add, and makes the build log usable again.

I was unable to find the build problem with #11021 without this.

@roberth roberth dismissed Ericson2314’s stale review July 12, 2024 16:04

Sorry, fixing the build log is more important

@roberth roberth added the contributor-experience Developer experience for Nix contributors label Jul 12, 2024
@edolstra edolstra enabled auto-merge July 12, 2024 16:05
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK fair enough, I'm convinced. It is an easy revert.

@edolstra edolstra merged commit 2a95a2d into master Jul 12, 2024
@edolstra edolstra deleted the darwin-no-map-spaceship branch July 12, 2024 16:40
@Ericson2314
Copy link
Member

I learned the problem is libc++ 16 is just too old. So yeah, we can't do this until Nixpkgs updates to a newer LLVM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor-experience Developer experience for Nix contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants