Restore commit-lock-file-summary rename for consistency#10988
Merged
roberth merged 2 commits intoNixOS:masterfrom Jun 29, 2024
Merged
Restore commit-lock-file-summary rename for consistency#10988roberth merged 2 commits intoNixOS:masterfrom
roberth merged 2 commits intoNixOS:masterfrom
Conversation
Merged
This comment was marked as resolved.
This comment was marked as resolved.
It was originally renamed in NixOS#10691, but NixOS#9063 accidentally removed the new name and alias.
cole-h
force-pushed
the
restore-summary-rename
branch
from
7421f94 to
d906d42
Compare
github-actions
bot
added
the
with-tests
Member
Author
|
OK, test added as the first commit. For me, it fails when I check out that commit, and passes when I check out the tip of this branch. I also noticed a little weirdness with aliases to settings and filed a bug here: #10989. Maybe this is intended / already has an open issue prior to mine / has been discussed before; if so, feel free to point me there (but I'll make the argument that if the "real" setting works as a flag (i.e. |
roberth
approved these changes
Jun 29, 2024
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Thank you Cole, and the test is much appreciated ❤️
rvolosatovs
added a commit
to rvolosatovs/nix-flake-update-action
that referenced
this pull request
Jul 12, 2024
NixOS/nix#10691 NixOS/nix#10988 Signed-off-by: Roman Volosatovs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was originally renamed in #10691, but #9063 accidentally removed the new name and alias.
Motivation
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.