Migrate internal API docs to Meson#10930
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jun 17, 2024
Merged
Conversation
github-actions
bot
added
documentation
contributor-experience
Ericson2314
reviewed
Jun 17, 2024
Comment on lines
-199
to
+200
| # nix build .#hydraJobs.internal-api-docs | ||
| # xdg-open ./result/share/doc/nix/internal-api/html/index.html | ||
| $ nix build .#hydraJobs.internal-api-docs | ||
| $ xdg-open ./result/share/doc/nix/internal-api/html/index.html |
Member
There was a problem hiding this comment.
By convention, # is for root shells, while $ is for regular user shells. (I wish I didn't know this silly Unix lore :D)
Ericson2314
approved these changes
Jun 17, 2024
Ericson2314
reviewed
Jun 17, 2024
src/internal-api-docs/meson.build
Outdated
| configuration : { | ||
| 'PROJECT_NUMBER': meson.project_version(), | ||
| 'OUTPUT_DIRECTORY' : meson.current_build_dir(), | ||
| 'src' : meson.project_source_root() / '..' / '..', |
Member
There was a problem hiding this comment.
https://mesonbuild.com/Fs-module.html#parent Maybe using that would be nicer
Ericson2314
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#2503
Context
@Ericson2314 @tomberek working on this
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.