Skip to content

Fix a compile error on windows#10927

Merged
roberth merged 1 commit intoNixOS:masterfrom
poweredbypie:windows-fix
Jun 17, 2024
Merged

Fix a compile error on windows#10927
roberth merged 1 commit intoNixOS:masterfrom
poweredbypie:windows-fix

Conversation

@poweredbypie
Copy link
Member

Context

There's a compile error on windows in the most current commit due to typing a parenthesis rather than a curly bracket.

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@poweredbypie poweredbypie requested a review from edolstra as a code owner June 17, 2024 07:05
@roberth roberth merged commit 5e0e0ec into NixOS:master Jun 17, 2024
@roberth
Copy link
Member

roberth commented Jun 17, 2024

Thanks!
We've previously decided not to CI the Windows bits, not to hinder progress on the supported platforms, but we'll add it at some point.

@poweredbypie
Copy link
Member Author

poweredbypie commented Jun 17, 2024

Thanks. I'll try to implement CI for Windows if I have time to read up on it!

@Ericson2314
Copy link
Member

@poweredbypie it's less something that needs to be implemented than just a matter of flipping a switch (shuffling some code around in flake.nix, it's already in `hydraJobs). It will be easier to think about after we've switched to Meson and there are not two build systems in flight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants